Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] Vue 3: Remove vuex-router-sync #8256

Merged
merged 1 commit into from
Jan 17, 2023
Merged

Conversation

JammingBen
Copy link
Contributor

Description

Remove vuex-router-sync because 1. it does not support vue-router v4 (vuejs/vue-hackernews-2.0@758961e#r50475667) and 2. we don't use it anyways (?)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen mentioned this pull request Jan 17, 2023
29 tasks
@JammingBen JammingBen force-pushed the remove-vuex-router-sync branch from dc94a56 to d23e35d Compare January 17, 2023 15:29
@JammingBen JammingBen force-pushed the remove-vuex-router-sync branch from d23e35d to d6f9bc7 Compare January 17, 2023 15:29
@sonarcloud
Copy link

sonarcloud bot commented Jan 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@dschmidt dschmidt merged commit 63879b5 into master Jan 17, 2023
@delete-merged-branch delete-merged-branch bot deleted the remove-vuex-router-sync branch January 17, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants